New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get background color from GtkMenuBar#menubar (3-0-x) #14812

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Sep 26, 2018

Description of Change

Backport of #14785 to 3-0-x.

Depends on #14809.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fixes incorrect background color on GTK menubar

@codebytere codebytere requested a review from electron/reviewers as a code owner Sep 26, 2018

@codebytere codebytere changed the title from fix: get background color from GtkMenuBar#menubar to fix: get background color from GtkMenuBar#menubar (3-0-x) Sep 26, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Sep 26, 2018

Member

Unrelated failure:

webContents module referrer propagates referrer information to new target=_blank windows - propagates referrer information to new target=_blank windows

Will merge once libcc roll is merged

Member

codebytere commented Sep 26, 2018

Unrelated failure:

webContents module referrer propagates referrer information to new target=_blank windows - propagates referrer information to new target=_blank windows

Will merge once libcc roll is merged

@codebytere codebytere merged commit 35cb671 into 3-0-x Sep 26, 2018

16 of 17 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 26, 2018

Release Notes Persisted

fixes incorrect background color on GTK menubar

release-clerk bot commented Sep 26, 2018

Release Notes Persisted

fixes incorrect background color on GTK menubar

@MarshallOfSound MarshallOfSound deleted the backport-gtk-menubar-3-0-x branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment