New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct key code reqs for accelerator doc (backport: 2-0-x) #14825

Merged
merged 1 commit into from Sep 27, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Sep 26, 2018

Backport of #14823

See that PR for details.

Notes: correct key code allowance for accelerator doc

@trop trop bot requested a review from electron/docs as a code owner Sep 26, 2018

@trop trop bot referenced this pull request Sep 26, 2018

Merged

docs: correct key code reqs for accelerator doc #14823

4 of 4 tasks complete

@trop trop bot added the backport label Sep 26, 2018

@MarshallOfSound MarshallOfSound merged commit d3c153e into electron:2-0-x Sep 27, 2018

12 of 13 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 27, 2018

Release Notes Persisted

correct key code allowance for accelerator doc

release-clerk bot commented Sep 27, 2018

Release Notes Persisted

correct key code allowance for accelerator doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment