New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable key accelerator flags for Windows and Linux (backport: 3-0-x) #14859

Merged
merged 3 commits into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Sep 28, 2018

Backport of #14830

See that PR for details.

Notes: Fixed Accelerator event flags to be on by default for Windows and Linux

@trop trop bot requested a review from electron/reviewers as a code owner Sep 28, 2018

@trop trop bot referenced this pull request Sep 28, 2018

Merged

fix: enable key accelerator flags for Windows and Linux #14830

5 of 5 tasks complete

@trop trop bot added the backport label Sep 28, 2018

@ckerr

ckerr approved these changes Sep 28, 2018

@ckerr

ckerr approved these changes Sep 28, 2018

@codebytere codebytere merged commit 5cd24a4 into electron:3-0-x Sep 28, 2018

12 of 13 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 28, 2018

Release Notes Persisted

Fixed Accelerator event flags to be on by default for Windows and Linux

release-clerk bot commented Sep 28, 2018

Release Notes Persisted

Fixed Accelerator event flags to be on by default for Windows and Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment