New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roll node deps for fs event patch #14864

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Member

codebytere commented Sep 28, 2018

Description of Change

Pulls in patch to fix #14844.

/cc @pfrazee

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fix fs_event_wrap assertion error in Node

@codebytere codebytere requested a review from electron/reviewers as a code owner Sep 28, 2018

@pfrazee

This comment has been minimized.

Show comment
Hide comment
@pfrazee

pfrazee Sep 28, 2018

Contributor

@codebytere Really appreciate you hitting this so quickly!

Contributor

pfrazee commented Sep 28, 2018

@codebytere Really appreciate you hitting this so quickly!

@deepak1556

LGTM, thanks!

@MarshallOfSound MarshallOfSound merged commit 385b088 into 3-0-x Sep 28, 2018

16 of 17 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 28, 2018

Release Notes Persisted

fix fs_event_wrap assertion error in Node

release-clerk bot commented Sep 28, 2018

Release Notes Persisted

fix fs_event_wrap assertion error in Node

@MarshallOfSound MarshallOfSound deleted the roll-node-3-0-x branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment