Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace var with const / let #14866

Merged
merged 1 commit into from Sep 28, 2018
Merged

refactor: replace var with const / let #14866

merged 1 commit into from Sep 28, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 28, 2018 •
edited

Description of Change

Disallow the use of var in JavaScript code (https://eslint.org/docs/rules/no-var), replace all occurrences with const or let as appropriate.

Checklist
Release Notes

Notes: no-notes

@miniak miniak requested review from a team September 28, 2018 18:52
@codebytere
Copy link
Member

there might be some cases where we need var, but we can just suppress the eslint warning for those

ckerr
ckerr approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miniak
Copy link
Contributor Author

miniak commented Sep 28, 2018

We need @deepak1556 for printing and @MarshallOfSound for updater approvals. Or @zcbenz or @groundwater who can approve both.

@miniak miniak self-assigned this Sep 28, 2018
@MarshallOfSound MarshallOfSound merged commit c61db52 into master Sep 28, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2018

No Release Notes

@MarshallOfSound MarshallOfSound deleted the miniak/disable-var branch September 28, 2018 23:17
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@groundwater groundwater Awaiting requested review from groundwater

@alexeykuzmin alexeykuzmin Awaiting requested review from alexeykuzmin

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @codebytere @ckerr @deepak1556 @MarshallOfSound