fix: simpleFullscreen window should be on top

[lynaghk]

First let me say that Electron is great and has empowered me to build fun + useful desktop software that I wouldn't have otherwise been able to create.
So thanks for your hard work and stewardship of the project --- if any of y'all catch me in person at a conference, etc., drinks are on me!

Description of Change

If an app has no menu bar (because app.dock.hide() has been called),
OS X will still render the menu bar of the previously-focused app.

This commit ensures simpleFullscreen windows will be drawn on top of
that menu bar by setting their level to NSPopUpMenuWindowLevel while
simpleFullscreen mode is active.

Ref: #11468

This fix is motivated by Finda, a keyboard-only app that needs to popup full screen on any OS X space without showing up in the Dock or with a menu bar.
The video on that page demonstrates this problem "in the wild" (note how Finda doesn't cover the QuickTime Player OS X menu bar when it pops up.)

Here's a reduced video showing before/after the fix:

Before fix the no_dock.js still shows iTerm's menu bar; after the fix the no_dock.js is actually fullscreen.
Included dock.js to show that this fix doesn't break menu bar when dock isn't hidden.

no_dock.js:

const electron = require('electron')
const app = electron.app
const BrowserWindow = electron.BrowserWindow

app.dock.hide()
app.on('ready', function(){
  new BrowserWindow({simpleFullscreen: true, fullscreen: true})
})

(dock.js is the same, but without the app.dock.hide() line.)

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines

Release Notes

Notes: Fixed simpleFullscreen windows in hidden-dock apps from being drawn below OS X menu bar of previously-focused app.

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codebytere]

this looks good, thanks for adding this!

[codebytere]

@lynaghk would you mind rebasing this on master?
Once that happens we should be good to merge! just want to get CI green 😁

[lynaghk]

No prob. Rebase was clean, I'll keep my fingers crossed for CI. Thanks for shepherding this through!

[alexeykuzmin]

Hi @lynaghk!
We currently have some issues with linux tests for PRs from forks, it will be resolved in #14984.
That's the reason why "linux-...-tests" jobs are show as failed for your PR.

[lynaghk]

Thanks for letting me know, @alexeykuzmin. I suspected it didn't have anything to do with my changes, so I wasn't taking the CI failures personally =P

[alexeykuzmin]

@lynaghk can you please rebase your branch onto the latest electron:master?
It is required to run CI builds on linux.

[lynaghk]

@alexeykuzmin Done. Rebase was clean. Thanks.

[codebytere]

@lynaghk one last rebase to bring in #15026, then we'll finally be good!

[lynaghk]

Done! Thanks for the reminders.

I'll pay additional tribute to the CI gods next harvest so that this doesn't happen again =P

[codebytere]

thanks! Our CI is a wild west right now owing to a recent build system change from gyp to GN so we appreciate the patience ✨

[codebytere]

Failure is

not ok 715 webContents module getWebPreferences() API should not crash when called for devTools webContents

which i believe to be unrelated

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

Fixed simpleFullscreen windows in hidden-dock apps from being drawn below OS X menu bar of previously-focused app.

[codebytere]

@lynaghk would you mind opening up backport PRs targeting 2-0-x and 3-0-x?

[lynaghk]

Happy to open PRs against those two branches. I'll get them submitted referencing this PR early next week.

…

On Wed, Oct 10, 2018 at 6:41 AM, Shelley Vohr ***@***.***> wrote: Merged #14881 <#14881> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14881 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJBzy8BjDAjcflDmn1yvqBDmaVQBR3xks5ujYhsgaJpZM4XAe7z> .

-- Kevin Lynagh Keming Labs *https://keminglabs.com <https://keminglabs.com>*1.888.502.1042