Skip to content

/electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Trigger an arm test on VSTS after CircleCI build #14898

Merged
merged 23 commits into from Oct 4, 2018
+289 −94

Conversation

Reviewers

@codebytere codebytere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jkleinsc @codebytere
@jkleinsc
Copy link
Contributor

commented Oct 1, 2018

Description of Change

This PR enables testing of our arm/arm64 builds on actual arm64 hardware via VSTS.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from as a code owner Oct 1, 2018

@jkleinsc jkleinsc force-pushed the test-arm-builds branch 2 times, most recently from 39b0a47 to 8dca20b Oct 2, 2018

@jkleinsc jkleinsc requested a review from as a code owner Oct 2, 2018

@codebytere

codebytere approved these changes Oct 3, 2018
View changes

@jkleinsc jkleinsc force-pushed the test-arm-builds branch from 8dca20b to 37323b9 Oct 3, 2018

jkleinsc and others added some commits Oct 3, 2018

@jkleinsc
Fix test script
Loading status checks…
3c94632
@jkleinsc
Fix yaml issue
Loading status checks…
415cc8d
@jkleinsc
Try running dbus tests
Loading status checks…
a87c846
@jkleinsc
Use better node header path
Loading status checks…
ca02c24
@jkleinsc @alexeykuzmin
Try adding builduser as sudoer 
Co-Authored-By: Alexey Kuzmin <github@alexeykuzmin.com>
Loading status checks…
b781d33
@jkleinsc
Setup arm docker containers with root as default user 
But still use builduser for npm install etc..
Loading status checks…
e4f6ec0
@jkleinsc
Add logging
Loading status checks…
da2ad71
@jkleinsc
more logging
Loading status checks…
67789b7
@jkleinsc
Try running arm64 build outside of docker
Loading status checks…
2a075a1
@jkleinsc
Fix dist download
Loading status checks…
638baf8
@jkleinsc
Fix dbus mock
Loading status checks…
dc5f829
@jkleinsc
Arrrrgh!
Loading status checks…
70aa9e6
@jkleinsc
Skip dbus testing
Loading status checks…
3bd68c6
@jkleinsc
Try using dbus_launch
Loading status checks…
2e5b1c2
@jkleinsc
Skip desktop capturer for arm
Loading status checks…
b12670b
@jkleinsc
Revert "Skip desktop capturer for arm" 
This reverts commit b12670b.
224d6d4
@jkleinsc
Revert "Try using dbus_launch" 
This reverts commit 2e5b1c2.
3939454
@jkleinsc
Revert "Skip dbus testing" 
This reverts commit 3bd68c6.
6a4ebfd
@jkleinsc
Run arm64 test in docker container
Loading status checks…
1c6b499
@jkleinsc
Revert "Revert "Skip desktop capturer for arm"" 
This reverts commit 224d6d4.
Loading status checks…
7c0ecff
@jkleinsc
Revert "Revert "Skip dbus testing"" 
This reverts commit 6a4ebfd.
Loading status checks…
7590bcf
@jkleinsc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 4, 2018

Merging as mac and windows failures are unrelated to this linux only change.

@jkleinsc jkleinsc merged commit 038b56e into master Oct 4, 2018
29 of 30 checks passed

29 of 30 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-native-mksnapshot Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-native-mksnapshot Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-verify-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-verify-ffmpeg Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Sign in to view
Copy link

commented Oct 4, 2018

No Release Notes

@jkleinsc jkleinsc deleted the test-arm-builds branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.