New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check guest view's devtools window size (backport: 3-0-x) #14928

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Oct 2, 2018

Backport of #14922

See that PR for details.

Notes: Fix the devtools window of webview being too small.

@trop trop bot requested a review from electron/reviewers as a code owner Oct 2, 2018

@trop trop bot referenced this pull request Oct 2, 2018

Merged

fix: check guest view's devtools window size #14922

3 of 5 tasks complete

@trop trop bot added the backport label Oct 2, 2018

@zcbenz zcbenz merged commit ee6de82 into electron:3-0-x Oct 3, 2018

11 of 13 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 3, 2018

Release Notes Persisted

Fix the devtools window of webview being too small.

release-clerk bot commented Oct 3, 2018

Release Notes Persisted

Fix the devtools window of webview being too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment