Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use white background for non-OSR renderer by default (2-0-x) #14933

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@zcbenz
Copy link
Member

zcbenz commented Oct 3, 2018

Backport #14932 to 2-0-x.

Notes: Fix subpixel AA fonts not working on Linux.

@zcbenz zcbenz requested a review from as a code owner Oct 3, 2018

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Oct 3, 2018

Failed unrelatedly on

crashReporter module with sandbox should send minidump when renderer crashes - should send minidump when renderer crashes

@codebytere codebytere merged commit 092796f into 2-0-x Oct 3, 2018

16 of 17 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 3, 2018

Release Notes Persisted

Fix subpixel AA fonts not working on Linux.

@zcbenz zcbenz deleted the renerer-background-white-2-0-x branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.