New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support ASAR in fs.copyFile (backport: 2-0-x) #14952

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@trop
Contributor

trop bot commented Oct 3, 2018

Backport of #14942

See that PR for details.

Close #14320

Notes: Fix fs.copyFile not working with ASAR archives.

@trop trop bot requested a review from electron/reviewers as a code owner Oct 3, 2018

@trop trop bot referenced this pull request Oct 3, 2018

Merged

fix: support ASAR in fs.copyFile #14942

4 of 4 tasks complete

@trop trop bot added the backport label Oct 3, 2018

@MarshallOfSound MarshallOfSound merged commit e55d7d6 into electron:2-0-x Oct 3, 2018

13 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 3, 2018

Release Notes Persisted

Fix fs.copyFile not working with ASAR archives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment