Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upci: use ubuntu 18.04 for arm testing #14988
+2
−2
Conversation
jkleinsc
requested a review
from
as a
code owner
Oct 5, 2018
ckerr
merged commit e06818e
into
master
Oct 5, 2018
20 checks passed
Semantic Pull Request
ready to be squashed
Details
WIP
ready for review
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests
Your tests passed on CircleCI!
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Oct 5, 2018
|
No Release Notes |
ckerr
deleted the
ubuntu1804-arm-docker
branch
Oct 5, 2018
jkleinsc
referenced this pull request
Oct 5, 2018
Merged
ci: cleanup Electron dirs before running tests #14989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jkleinsc commentedOct 5, 2018
Description of Change
Our arm tests are failing because of the version of glibc install on our docker container:
./out/Default/electron: /lib/arm-linux-gnueabihf/libc.so.6: version 'GLIBC_2.27' not found (required by ./out/Default/electron).This PR updates our docker container for arm to Ubuntu 18.04
Checklist
npm testpassesRelease Notes
Notes: no-notes