New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu 18.04 for arm testing #14988

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented Oct 5, 2018

Description of Change

Our arm tests are failing because of the version of glibc install on our docker container:
./out/Default/electron: /lib/arm-linux-gnueabihf/libc.so.6: version 'GLIBC_2.27' not found (required by ./out/Default/electron).

This PR updates our docker container for arm to Ubuntu 18.04

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Oct 5, 2018

@ckerr

ckerr approved these changes Oct 5, 2018

🎉

@ckerr ckerr merged commit e06818e into master Oct 5, 2018

20 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 5, 2018

No Release Notes

@ckerr ckerr deleted the ubuntu1804-arm-docker branch Oct 5, 2018

@jkleinsc jkleinsc referenced this pull request Oct 5, 2018

Merged

ci: cleanup Electron dirs before running tests #14989

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment