New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the upload distribution step on VSTS #15015

Merged
merged 3 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Oct 8, 2018

Description of Change

Nightly builds have been failing lately because the upload.py script couldn't find Electron's binary.
https://github.visualstudio.com/electron/_build/results?buildId=13965&view=logs

A build after the fix https://github.visualstudio.com/electron/_build/results?buildId=14070&view=logs

/cc @jkleinsc

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin requested a review from MarshallOfSound Oct 8, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Oct 8, 2018

@alexeykuzmin alexeykuzmin changed the title from ci: fix the upload distribution step on VSTS to [wip] ci: fix the upload distribution step on VSTS Oct 8, 2018

@ckerr

ckerr approved these changes Oct 8, 2018

@alexeykuzmin alexeykuzmin changed the title from [wip] ci: fix the upload distribution step on VSTS to ci: fix the upload distribution step on VSTS Oct 8, 2018

@alexeykuzmin alexeykuzmin changed the title from ci: fix the upload distribution step on VSTS to [wip] ci: fix the upload distribution step on VSTS Oct 8, 2018

@alexeykuzmin alexeykuzmin changed the title from [wip] ci: fix the upload distribution step on VSTS to ci: fix the upload distribution step on VSTS Oct 8, 2018

@ckerr

ckerr approved these changes Oct 8, 2018

@ckerr ckerr merged commit 7866575 into master Oct 8, 2018

22 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
nightly-release-osx-x64 #20181008.7 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 8, 2018

Release Notes Persisted

no notes

@ckerr ckerr deleted the fix-upload-distribution-on-vsts branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment