New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add extension to .eslintrc file #15020

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@ManoelLobo
Contributor

ManoelLobo commented Oct 8, 2018

.eslintrc file without extension is deprecated.
(https://eslint.org/docs/user-guide/configuring#configuration-file-formats)

Description of Change

Add .json extension to .eslintrc file

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: Add extension to .eslintrc

chore(eslint): add extension to .eslintrc file
.eslintrc file without extension is deprecated.

@ManoelLobo ManoelLobo requested a review from electron/reviewers as a code owner Oct 8, 2018

@welcome

This comment has been minimized.

welcome bot commented Oct 8, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@ManoelLobo ManoelLobo changed the title from chore(eslint): add extension to .eslintrc file to chore: add extension to .eslintrc file Oct 8, 2018

@ckerr

ckerr approved these changes Oct 8, 2018

Thanks!

@ckerr

This comment has been minimized.

Member

ckerr commented Oct 8, 2018

Merging despite CI failures because the CI failures are unrelated to this PR.

@ckerr ckerr merged commit 5416051 into electron:master Oct 8, 2018

14 of 19 checks passed

ci/circleci: linux-arm-testing Your tests failed on CircleCI
Details
ci/circleci: linux-arm64-testing Your tests failed on CircleCI
Details
ci/circleci: linux-ia32-testing Your tests failed on CircleCI
Details
ci/circleci: linux-x64-testing Your tests failed on CircleCI
Details
ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 8, 2018

Release Notes Persisted

Add extension to .eslintrc

@welcome

This comment has been minimized.

welcome bot commented Oct 8, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment