New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backport of #14648 #15025

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@Kthulu120
Contributor

Kthulu120 commented Oct 8, 2018

Description of Change

Backport of #14648 to restore maximizable state of window when setResizable is toggled.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are [changed or added]
  • PR title follows semantic [commit guidelines]
Release Notes

Notes: Allows the window to be maximization status to be restored to previous value upon being resizable again.

@Kthulu120 Kthulu120 requested a review from electron/reviewers as a code owner Oct 8, 2018

@ckerr

ckerr approved these changes Oct 8, 2018

@ckerr ckerr merged commit 2663d3e into 2-0-x Oct 9, 2018

18 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 9, 2018

Release Notes Persisted

Allows the window to be maximization status to be restored to previous value upon being resizable again.

@ckerr ckerr deleted the kthulu120/setResizable branch Oct 9, 2018

@ckerr

This comment has been minimized.

Member

ckerr commented Oct 9, 2018

/trop run backport-to 3-0-x

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 9, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-0-x" here we go! :D

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 9, 2018

We have automatically backported this PR to "3-0-x", please check out #15032

@trop trop bot added the merged/3-0-x label Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment