New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check dbus response for null before use. #15033

Merged
merged 3 commits into from Oct 12, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Member

ckerr commented Oct 9, 2018

Description of Change

Fix: backport #15030 to fix #14958 dbus crash, re-enable power monitor tests.

Manual backport was required because between 3.0.0 and master the tests were refactored to use BDD-style syntax.

CC @alexeykuzmin @deepak1556

Checklist
Release Notes

Notes: Fixed crash when login1 manager dbus calls failed.

ckerr added some commits Oct 9, 2018

@ckerr ckerr requested a review from electron/reviewers as a code owner Oct 9, 2018

@ckerr ckerr changed the title from fix: power observer dbus crash to [wip] fix: power observer dbus crash Oct 9, 2018

@deepak1556

LGTM, the windows failure can be ignored, but the linux crash seems to be related.

chore: undo changes made to power monitor tests.
The Linux failures on that are gone in master / 4-0-x.  Whatever
resolved it there is unrelated to this PR's changes, so I'm not
going to block this fix on an unrelated issue.

@ckerr ckerr changed the title from [wip] fix: power observer dbus crash to fix: power observer dbus crash Oct 11, 2018

@ckerr ckerr changed the title from fix: power observer dbus crash to fix: check dbus response for null before use. Oct 11, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Oct 12, 2018

Both test failures are confirmed flakes (loginitem, app on exit)

@codebytere codebytere merged commit eb8546c into 3-0-x Oct 12, 2018

16 of 18 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 12, 2018

Release Notes Persisted

Fixed crash when login1 manager dbus calls failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment