New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check minSize constraints before resizing (backport: 3-0-x) #15038

Merged
merged 7 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Oct 9, 2018

Backport of #14931

See that PR for details.

Notes: Snap to minimum size possible when setSize is called below size constraints

@trop trop bot requested review from electron/docs as code owners Oct 9, 2018

@trop trop bot referenced this pull request Oct 9, 2018

Merged

fix: Check minSize constraints before resizing #14931

5 of 5 tasks complete

@trop trop bot added the backport label Oct 9, 2018

@ckerr

ckerr approved these changes Oct 9, 2018

@nornagon nornagon merged commit 524bb99 into electron:3-0-x Oct 9, 2018

12 of 14 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 9, 2018

Release Notes Persisted

Snap to minimum size possible when setSize is called below size constraints

release-clerk bot commented Oct 9, 2018

Release Notes Persisted

Snap to minimum size possible when setSize is called below size constraints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment