New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lifetime of auth_info_ in login handler (backport: 3-0-x) #15044

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
4 participants
@trop

trop bot commented Oct 9, 2018

Backport of #15042

See that PR for details.

Notes: Fixed crash in proxy login handler

@trop trop bot requested a review from electron/reviewers as a code owner Oct 9, 2018

@trop trop bot referenced this pull request Oct 9, 2018

Merged

fix: Lifetime of auth_info_ in login handler #15042

0 of 5 tasks complete

@trop trop bot added the backport label Oct 9, 2018

@MarshallOfSound MarshallOfSound referenced this pull request Oct 9, 2018

Closed

fix: auth_info lifetime in loginhandler #15002

0 of 5 tasks complete
@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Oct 10, 2018

Member

Windows CI failure is unrelated, as is the MAS failure

Member

MarshallOfSound commented Oct 10, 2018

Windows CI failure is unrelated, as is the MAS failure

@MarshallOfSound MarshallOfSound merged commit 3d8af9d into electron:3-0-x Oct 10, 2018

12 of 14 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 10, 2018

Release Notes Persisted

Fixed crash in proxy login handler

release-clerk bot commented Oct 10, 2018

Release Notes Persisted

Fixed crash in proxy login handler

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Oct 11, 2018

Member

As per #15002 (comment) this should fix:

#14655
#14411

Member

ckerr commented Oct 11, 2018

As per #15002 (comment) this should fix:

#14655
#14411

@bughit

This comment has been minimized.

Show comment
Hide comment
@bughit

bughit Oct 11, 2018

Contributor

did not fix #14411

Contributor

bughit commented Oct 11, 2018

did not fix #14411

@bughit

This comment has been minimized.

Show comment
Hide comment
@bughit

bughit Oct 11, 2018

Contributor

did not fix #14655

Contributor

bughit commented Oct 11, 2018

did not fix #14655

@ckerr ckerr referenced this pull request Oct 12, 2018

Open

3.0.x auto-generated release notes are difficult to read #15116

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment