New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SetSize() should honor minSize (#13994) #15052

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Member

ckerr commented Oct 10, 2018

Description of Change

Manual backport of #14931 to fix #13994, enforcing window minimum height/width

@Kthulu120 @nornagon

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: setSize() now honors minimum size constraints.

@ckerr ckerr requested review from electron/docs as code owners Oct 10, 2018

@ckerr

This comment has been minimized.

Member

ckerr commented Oct 10, 2018

merging despite ci/circleci: electron-mas-x64 CI failure because that is a known & reported flake

@ckerr ckerr merged commit 28a160f into 2-0-x Oct 10, 2018

17 of 18 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 10, 2018

Release Notes Persisted

setSize() now honors minimum size constraints.

@ckerr ckerr deleted the minSizeConstraints_2-0-x branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment