New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: strip linux binaries for nightly release builds #15063

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
4 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Oct 10, 2018

Description of Change

/cc @jkleinsc

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Oct 10, 2018

@@ -24,6 +24,7 @@ env-testing-build: &env-testing-build
env-release-build: &env-release-build
GN_CONFIG: //electron/build/args/release.gn
STRIP_BINARIES: true

This comment has been minimized.

@nornagon

nornagon Oct 10, 2018

Contributor

this should be set on testing builds too

@nornagon

nornagon Oct 10, 2018

Contributor

this should be set on testing builds too

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Oct 10, 2018

Contributor

@deepak1556 what do you think?

@alexeykuzmin

alexeykuzmin Oct 10, 2018

Contributor

@deepak1556 what do you think?

This comment has been minimized.

@deepak1556

deepak1556 Oct 10, 2018

Member

I was thinking binaries used in CI testing can remain as such, since we tend to disable them at some point for debugging. Wouldn't it be okay if its just for release builds ?

@deepak1556

deepak1556 Oct 10, 2018

Member

I was thinking binaries used in CI testing can remain as such, since we tend to disable them at some point for debugging. Wouldn't it be okay if its just for release builds ?

This comment has been minimized.

@nornagon

nornagon Oct 10, 2018

Contributor

ah right, yes, ignore me. deepak is right. morning brain strikes again!

@nornagon

nornagon Oct 10, 2018

Contributor

ah right, yes, ignore me. deepak is right. morning brain strikes again!

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Oct 10, 2018

Contributor

@nornagon mind to approve then? )

@alexeykuzmin

alexeykuzmin Oct 10, 2018

Contributor

@nornagon mind to approve then? )

@alexeykuzmin alexeykuzmin changed the title from ci: strip linux binaries for nightly release builds to [wip] ci: strip linux binaries for nightly release builds Oct 10, 2018

@alexeykuzmin alexeykuzmin changed the title from [wip] ci: strip linux binaries for nightly release builds to ci: strip linux binaries for nightly release builds Oct 10, 2018

@MarshallOfSound MarshallOfSound merged commit a9646e3 into master Oct 11, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 11, 2018

Release Notes Persisted

no notes

release-clerk bot commented Oct 11, 2018

Release Notes Persisted

no notes

@MarshallOfSound MarshallOfSound deleted the strip-binaries branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment