New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workingDirectory to shell.openExternal() options #15065

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
4 participants
@miniak
Contributor

miniak commented Oct 10, 2018

Description of Change

Allows passing workingDirectory to the underlying ShellExecuteW API on Windows.

the motivation is that by default ShellExecute would use the current working directory, which would get locked on Windows and can prevent autoUpdater from working correctly. We need to be able specify a different workingDirectory to prevent this situation.

Checklist
Release Notes

Notes: Added workingDirectory to shell.openExternal() options (Windows only)

@miniak miniak requested review from electron/docs as code owners Oct 10, 2018

@nornagon

Code looks OK, but I'm curious what the use case is for this. Also, would it make sense to implement this on Linux too?

@alexeykuzmin alexeykuzmin merged commit a9475f3 into master Oct 10, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 10, 2018

Release Notes Persisted

Added workingDirectory to shell.openExternal() options (Windows only)

release-clerk bot commented Oct 10, 2018

Release Notes Persisted

Added workingDirectory to shell.openExternal() options (Windows only)

@alexeykuzmin alexeykuzmin deleted the miniak/open-external-working-dir branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment