New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle shortcuts by default if no WebPreferences object exists (backport: 3-0-x) #15066

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Oct 10, 2018

Description of Change

Backport of #14766.

/cc @MarshallOfSound

Checklist
Release Notes

Notes: handle shortcuts by default if no WebPreferences object exists

@codebytere codebytere requested a review from electron/reviewers as a code owner Oct 10, 2018

@codebytere codebytere changed the title from fix: handle shortcuts by default if no WebPreferences object exists to fix: handle shortcuts by default if no WebPreferences object exists (backport: 3-0-x) Oct 10, 2018

@ckerr

ckerr approved these changes Oct 10, 2018

💚

@MarshallOfSound MarshallOfSound merged commit 502b0b9 into 3-0-x Oct 11, 2018

16 of 17 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 11, 2018

Release Notes Persisted

handle shortcuts by default if no WebPreferences object exists

release-clerk bot commented Oct 11, 2018

Release Notes Persisted

handle shortcuts by default if no WebPreferences object exists

@MarshallOfSound MarshallOfSound deleted the backport-menu-sc-devtools branch Oct 11, 2018

@ckerr ckerr referenced this pull request Oct 12, 2018

Open

3.0.x auto-generated release notes are difficult to read #15116

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment