New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not create node environment in child window if node integration is not enabled #15076
Conversation
We'd have to do that in 5.x to follow semver (deprecate / warn in 4.x) |
1054b57
to
486300e
Compare
Manually backported to 2-0-x and 3-0-x as in above links. I'll create new PRs that: |
486300e
to
d4c9908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicting but seems 🆗
d4c9908
to
fb36cff
Compare
Release Notes Persisted
|
…on (#15213) * fix: child window with nativeWindowOpen should disable node integration * Revert "fix: do not enable node integration in child window if not enabled (#15076)" This reverts commit 0252d76. This patch is not needed anymore since we are force disabling node integration for child windows.
Description of Change
Since we don't release Node environments (to avoid crashes), child windows opened with
nativeWindowOpen
option will have their V8 contexts leaks. This PR avoids creating Node environment in child windows if the node integration is not enabled there.So this PR serves as a partial fix for #12634, users should make sure node integration is not enabled in the child windows to avoid memory leaks.
As a complete fix for this problem, I propose:
nativeWindowOpen
.Checklist
npm test
passesRelease Notes
Notes: Partially fix the memory leak when opening child windows with
nativeWindowOpen
.