New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "FIXME: disable isCurrentlyAudible test to unblock merge" (backport: 4-0-x) #15083

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Oct 11, 2018

Backport of #15078

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from electron/reviewers as a code owner Oct 11, 2018

@trop trop bot referenced this pull request Oct 11, 2018

Merged

revert: "FIXME: disable isCurrentlyAudible test to unblock merge" #15078

3 of 3 tasks complete

@trop trop bot added the backport label Oct 11, 2018

@ckerr

ckerr approved these changes Oct 11, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Oct 11, 2018

Member

merging despite unrelated CI failure.

Member

ckerr commented Oct 11, 2018

merging despite unrelated CI failure.

@ckerr ckerr merged commit cfbb22b into electron:4-0-x Oct 11, 2018

20 of 21 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Oct 11, 2018

No Release Notes

release-clerk bot commented Oct 11, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment