New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check dbus response for null before use. #15088

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@ckerr
Member

ckerr commented Oct 11, 2018

Description of Change

Fixes #14958.

Manual backport of #15030 to fix a pair of power-monitor bugs:

  • nullptr dereference in dbus response handling (14958)
  • redundant dbus signal subscriptions

cc @alexeykuzmin

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: Fixed crash when login1 manager dbus calls failed.

Check dbus response for null before using.
Fixes #14958.

Manual backport of #15030. Drops some the BindOnce improvements
due to compile issues with older version of Chromium.

@ckerr ckerr requested a review from electron/reviewers as a code owner Oct 11, 2018

@ckerr ckerr changed the title from fix: check dbus response for null before using. to fix: check dbus response for null before use. Oct 11, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Oct 12, 2018

Failing on unrelated

app module app.get/setLoginItemSettings API returns the login item status of the app - returns the login item status of the app

@codebytere codebytere merged commit 411f2be into 2-0-x Oct 12, 2018

17 of 18 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 12, 2018

Release Notes Persisted

Fixed crash when login1 manager dbus calls failed.

@codebytere codebytere deleted the fix-power-observer-dbus_2-0-x branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment