New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move color_chooser out of chromium_src #15091

Merged
merged 3 commits into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@brenca
Member

brenca commented Oct 11, 2018

Description of Change

This PR moves the color chooser dialog out of chromium_src and implements the necessary changes as a patch instead

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@brenca brenca requested review from nornagon and deepak1556 Oct 11, 2018

@brenca brenca requested a review from electron/reviewers as a code owner Oct 11, 2018

if (is_mac) {
sources += [
"//chrome/browser/ui/cocoa/color_chooser_mac.h",
"//chrome/browser/ui/cocoa/color_chooser_mac.mm",

This comment has been minimized.

@nornagon

nornagon Oct 11, 2018

Contributor

FYI, anything in a cocoa/ directory on with _mac in its name is automatically only included in sources if is_mac. See https://chromium.googlesource.com/chromium/src/+/69.0.3497.106/build/config/BUILDCONFIG.gn#398

This comment has been minimized.

@brenca

@MarshallOfSound MarshallOfSound merged commit 5ef5d60 into master Oct 11, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 11, 2018

No Release Notes

@MarshallOfSound MarshallOfSound deleted the refactor-color-chooser branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment