Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu accelerators not working #15094

Merged
merged 8 commits into from Nov 9, 2018

Conversation

Projects
None yet
4 participants
@nitsakh
Copy link
Contributor

commented Oct 11, 2018

Description of Change

This PR fixes #14252.
Menu Accelerators were not working on Linux with Unity, global menus.

Checklist
Release Notes

Notes: Fixed bug that caused menu accelerators to stop working on some linux

@nitsakh nitsakh requested a review from as a code owner Oct 11, 2018

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2018

LGTM once the CI passes :)

Show resolved Hide resolved spec/api-menu-spec.js Outdated

@nitsakh nitsakh referenced this pull request Oct 15, 2018

Merged

fix: Menu accelerators not working Unity #15181

0 of 5 tasks complete

@nitsakh nitsakh force-pushed the menu-fix branch 2 times, most recently from 0ad34e4 to a7ef8a1 Oct 16, 2018

@nitsakh nitsakh force-pushed the menu-fix branch from a7ef8a1 to e7976df Nov 2, 2018

Update api-menu-spec.js
Try sending robot keys differently

@nitsakh nitsakh referenced this pull request Nov 6, 2018

Merged

fix: Linux empty menu model handling #15605

0 of 5 tasks complete

nitsakh added some commits Nov 6, 2018

@codebytere

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

@nitsakh what's the current status of this?

@nitsakh

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

@codebytere it'll be great if you can please take another look at this one. Should be ready to merge once approved again.

@nitsakh nitsakh merged commit 5994bf6 into master Nov 9, 2018

27 of 29 checks passed

Backportable? - 3-0-x Backport Failed
Details
Backportable? - 4-0-x Backport Failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181109.18 succeeded
Details
electron-arm64-testing Build #20181109.19 succeeded
Details
electron-lint Build #20181109.22 succeeded
Details
electron-mas-testing Build #20181109.24 succeeded
Details
electron-osx-testing Build #20181109.25 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 9, 2018

Release Notes Persisted

Fixed bug that caused menu accelerators to stop working on some linux

@nitsakh nitsakh deleted the menu-fix branch Nov 9, 2018

@trop

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

I was unable to backport this PR to "3-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

nitsakh added a commit that referenced this pull request Nov 9, 2018

fix: Menu accelerators not working (#15094)
This change fixes the regression in the menu accelerators working in linux, on some environments.

codebytere added a commit that referenced this pull request Nov 10, 2018

fix: Menu accelerators not working (#15094) (#15662)
This change fixes the regression in the menu accelerators working in linux, on some environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.