Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: natively implement LoginItem functions (backport: 4-0-x) #15127

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Oct 12, 2018

Backport of #15010

See that PR for details.

Notes: fixes issue with setting and unsetting an app as a LoginItem

@trop trop bot requested a review from as a code owner Oct 12, 2018

@trop trop bot referenced this pull request Oct 12, 2018

Merged

fix: natively implement LoginItem functions #15010

3 of 3 tasks complete

@trop trop bot added the backport label Oct 12, 2018

@MarshallOfSound MarshallOfSound merged commit 3ee697b into electron:4-0-x Oct 13, 2018

20 of 21 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 13, 2018

Release Notes Persisted

fixes issue with setting and unsetting an app as a LoginItem

@ckerr ckerr referenced this pull request Dec 18, 2018

Closed

Draft 4.0.0 Release Notes #16117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.