New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: natively implement LoginItems methods (backport: 3-0-x) #15139 #15128

Merged
merged 2 commits into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Oct 12, 2018

Description of Change

Backport of #15010.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fixes issue with setting and unsetting an app as a LoginItem

@codebytere codebytere requested a review from electron/reviewers as a code owner Oct 12, 2018

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Oct 13, 2018

@codebytere Unfortunately the test this is supposed to fix failed on this PR.

https://circleci.com/gh/electron/electron/83170

@codebytere codebytere merged commit f6b7f54 into 3-0-x Oct 13, 2018

18 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 13, 2018

Release Notes Persisted

fixes issue with setting and unsetting an app as a LoginItem

@codebytere

This comment has been minimized.

Member

codebytere commented Oct 13, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 13, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "2-0-x" here we go! :D

@codebytere codebytere deleted the loginitem-bp-3-0-x branch Oct 13, 2018

@alexeykuzmin alexeykuzmin changed the title from fix: natively implement LoginItems methods to fix: natively implement LoginItems methods (backport: 3-0-x) #15139 Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment