New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: natively implement LoginItem functions (backport: 2-0-x) #15139

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Oct 13, 2018

Description of Change

Backport of #15010.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fixes issue with setting and unsetting an app as a LoginItem

@codebytere codebytere requested a review from electron/reviewers as a code owner Oct 13, 2018

@codebytere codebytere changed the title from fix: natively implement LoginItem functions to fix: natively implement LoginItem functions (backport: 2-0-x) Oct 13, 2018

// Wait because login item settings are not applied immediately in MAS build
const delay = process.mas ? 100 : 0
const delay = process.mas ? 150 : 0

This comment has been minimized.

@nornagon

nornagon Oct 15, 2018

Contributor

is there a way we could poll or otherwise get a notification for this? not blocking the backport because this is still an improvement, but getting rid of timeouts like these is a great way to reduce flakiness

This comment has been minimized.

@codebytere

codebytere Oct 15, 2018

Member

good question! i can look into it sometime soon 🚀

@codebytere codebytere merged commit b8eec43 into 2-0-x Oct 15, 2018

18 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 15, 2018

Release Notes Persisted

fixes issue with setting and unsetting an app as a LoginItem

@codebytere codebytere deleted the loginitem-bp-2-0-x branch Oct 15, 2018

@swapnil0545

This comment has been minimized.

swapnil0545 commented Oct 16, 2018

When can I expect this to be in a released version? Or when is the next version scheduled for release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment