New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: printing #15143

Merged
merged 3 commits into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@deepak1556
Member

deepak1556 commented Oct 13, 2018

Description of Change

Followup for #15023

  • Registers pdf compositor service for generating pdf with OOPIF
  • Cleans up printing sources and dependencies

Fixes #14260
Fixes #9537
Fixes #15188

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@deepak1556 deepak1556 requested review from electron/printing as code owners Oct 13, 2018

@deepak1556 deepak1556 changed the title from [WIP] refactor: printing to refactor: printing Nov 4, 2018

@jkleinsc

LGTM

@brenca

I see that you added isPrintingEnabled to put the specs behind a flag, but I can't see any changes to the specs themselves. Was that intentional? Otherwise LGTM!

deepak1556 added some commits Oct 12, 2018

refactor: basic printing
* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources
@deepak1556

This comment has been minimized.

Member

deepak1556 commented Nov 8, 2018

but I can't see any changes to the specs themselves. Was that intentional?

@brenca missed isolating the specs, have fixed them now. Thanks!

@MarshallOfSound

LGTM

@MarshallOfSound MarshallOfSound merged commit 8232296 into master Nov 9, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 9, 2018

No Release Notes

@MarshallOfSound MarshallOfSound deleted the printing_cleanup branch Nov 9, 2018

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 9, 2018

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@popod

This comment has been minimized.

Contributor

popod commented Nov 13, 2018

Hi @deepak1556 ! Where can I follow the achievement of backporting this PR for 3-x-x as said in some of the related issues ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment