New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve background color through reload (backport: 3-0-x) #15175

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@adill
Contributor

adill commented Oct 15, 2018

Backport of #15105

See that PR for details.

Notes: fix: backgroundColor is preserved through reload

@adill adill requested a review from codebytere Oct 15, 2018

@adill adill requested a review from electron/reviewers as a code owner Oct 15, 2018

@adill adill referenced this pull request Oct 15, 2018

Merged

fix: preserve background color through reload #15105

2 of 2 tasks complete
@codebytere

ty @adill

@codebytere codebytere merged commit 2259747 into electron:3-0-x Oct 15, 2018

14 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 15, 2018

Release Notes Persisted

fix: backgroundColor is preserved through reload

@adill adill deleted the discordapp:fix-bgcolor-reload-3-0-x branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment