New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not create node environment in child window if node integration is not enabled (4-0-x) #15190

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Oct 16, 2018

Backport #15076 to 4-0-x.

Notes: Partially fix the memory leak when opening child windows with nativeWindowOpen.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Oct 16, 2018

@zcbenz zcbenz merged commit 0c09199 into 4-0-x Oct 16, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 16, 2018

Release Notes Persisted

Partially fix the memory leak when opening child windows with nativeWindowOpen.

@zcbenz zcbenz deleted the no-node-integration-in-child-window-4-0-x branch Oct 16, 2018

@zcbenz zcbenz changed the title from fix: do not create node environment in child window if node integration is not enabled to fix: do not create node environment in child window if node integration is not enabled (4-0-x) Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment