New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecation warning for using nativeWindowOpen with nodeIntegration (4-0-x) #15193

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Oct 16, 2018

Description of Change

Print a deprecation warning when the child windows opened with nativeWindowOpen option have node integration.

Refs #12634, #15076 (comment).

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Print a deprecation warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz requested review from electron/docs as code owners Oct 16, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Oct 16, 2018

Need to fix TypeError: console.warn is not a function

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Oct 17, 2018

It looks like the code is executed when did-stop-loading event happens, and the DOM may have not been ready at that time.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Oct 17, 2018

Delaying the warning to dom-ready has fixed the failed tests.

@zcbenz zcbenz merged commit 5fbf1f9 into 4-0-x Oct 17, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 17, 2018

Release Notes Persisted

Print a deprecation warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz deleted the window-open-warn-leak-4-0-x branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment