New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add width to webview iframe (backport: 4-0-x) #15205

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@trop
Contributor

trop bot commented Oct 17, 2018

Backport of #15195

See that PR for details.

Notes: Fix webview can not be resized to less than 300px.

@trop trop bot requested a review from electron/reviewers as a code owner Oct 17, 2018

@trop trop bot referenced this pull request Oct 17, 2018

Merged

add width to webview iframe #15195

@trop trop bot added the backport label Oct 17, 2018

@zcbenz zcbenz changed the title from add width to webview iframe (backport: 4-0-x) to fix: add width to webview iframe (backport: 4-0-x) Oct 17, 2018

@zcbenz zcbenz merged commit f1a8483 into electron:4-0-x Oct 17, 2018

19 of 20 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 17, 2018

Release Notes Persisted

Fix webview can not be resized to less than 300px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment