New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security: add an option to disable the remote module (backport: 4-0-x) #15222

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@trop
Contributor

trop bot commented Oct 17, 2018

Backport of #13028

See that PR for details.

undefined

Notes: Added webPreferences.enableRemoteModule option allowing to disable the remote module to increase sandbox security.

@trop trop bot requested review from electron/docs as code owners Oct 17, 2018

@trop trop bot referenced this pull request Oct 17, 2018

Merged

feat: security: add an option to disable the remote module #13028

5 of 5 tasks complete

@trop trop bot added the backport label Oct 17, 2018

@alexeykuzmin alexeykuzmin added the wip label Oct 17, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Oct 17, 2018

This PR requires an explicit approval from the team to be merged since it brings in a new feature to a beta release line.
Please remove the wip label only when it's approved.

@codebytere

This comment has been minimized.

Member

codebytere commented Oct 17, 2018

(approved pending group approval at next kickoff)

@alexeykuzmin alexeykuzmin removed the wip label Oct 22, 2018

@groundwater

Approved by unanimous vote!

@alexeykuzmin alexeykuzmin changed the title from feat: security: add an option to disable the remote module (backport: 4-0-x) to [wip] feat: security: add an option to disable the remote module (backport: 4-0-x) Oct 22, 2018

@alexeykuzmin alexeykuzmin changed the title from [wip] feat: security: add an option to disable the remote module (backport: 4-0-x) to feat: security: add an option to disable the remote module (backport: 4-0-x) Oct 22, 2018

@alexeykuzmin alexeykuzmin merged commit a313aae into electron:4-0-x Oct 23, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 23, 2018

Release Notes Persisted

Added webPreferences.enableRemoteModule option allowing to disable the remote module to increase sandbox security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment