Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow renaming electron.exe (backport: 4-0-x) #15249

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Oct 18, 2018

Backport of #15173

See that PR for details.

Notes: fix an issue preventing the electron.exe executable from being renamed on Windows when using native modules

@trop trop bot requested a review from as a code owner Oct 18, 2018

@trop trop bot referenced this pull request Oct 18, 2018

Merged

fix: allow renaming electron.exe #15173

3 of 4 tasks complete

@trop trop bot added the backport label Oct 18, 2018

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Oct 18, 2018

/cc @sofianguy It blocks everyone.

@nornagon

This comment has been minimized.

Copy link
Contributor

nornagon commented Oct 18, 2018

please don't merge until appveyor runs here.

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Oct 18, 2018

please don't merge until appveyor runs here.

I added to the wip label to prevent "all green checks" and accidental merging.

@MarshallOfSound MarshallOfSound added wip and removed wip labels Oct 18, 2018

@MarshallOfSound MarshallOfSound merged commit 96a4fce into electron:4-0-x Oct 18, 2018

19 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 18, 2018

Release Notes Persisted

fix an issue preventing the electron.exe executable from being renamed on Windows when using native modules

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Oct 18, 2018

Merging as discussed in #release-coordination

@ckerr ckerr referenced this pull request Dec 18, 2018

Closed

Draft 4.0.0 Release Notes #16117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.