New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable use of NODE_OPTIONS env var (backport: 4-0-x) #15259

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Oct 18, 2018

Backport of #15158

See that PR for details.

Notes: Enable use of NODE_OPTIONS env var

@trop trop bot requested review from electron/docs as code owners Oct 18, 2018

@trop trop bot referenced this pull request Oct 18, 2018

Merged

fix: enable use of NODE_OPTIONS env var #15158

3 of 3 tasks complete

@trop trop bot added the backport label Oct 18, 2018

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Oct 19, 2018

Windows failures not caught on original PR due to AppVeyor being down, fixed in #15266

@codebytere codebytere merged commit 435ca8c into electron:4-0-x Oct 19, 2018

17 of 21 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 19, 2018

Release Notes Persisted

Enable use of NODE_OPTIONS env var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment