New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: roll node (backport: 4-0-x) #15260

Merged
merged 2 commits into from Oct 19, 2018

Conversation

Projects
None yet
4 participants
@trop
Contributor

trop bot commented Oct 18, 2018

Backport of #15177

See that PR for details.

Notes: fix an issue where N-API and zlib symbols weren't correctly exported on windows, and also enable support for the NODE_OPTIONS environment variable

nornagon and others added some commits Oct 15, 2018

@trop trop bot requested a review from electron/reviewers as a code owner Oct 18, 2018

@trop trop bot referenced this pull request Oct 18, 2018

Merged

chore: roll node #15177

2 of 2 tasks complete

@trop trop bot added the backport label Oct 18, 2018

adill added a commit to discordapp/electron that referenced this pull request Oct 19, 2018

@codebytere codebytere merged commit fd4d032 into electron:4-0-x Oct 19, 2018

19 of 21 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 19, 2018

Release Notes Persisted

fix an issue where N-API and zlib symbols weren't correctly exported on windows, and also enable support for the NODE_OPTIONS environment variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment