New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: asyncawaitify one of sandbox related tests (backport: 3-0-x) #15281

Merged
merged 2 commits into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Oct 19, 2018

Backport of #15252

See that PR for details.

Notes: no notes

@alexeykuzmin alexeykuzmin requested a review from codebytere Oct 19, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Oct 19, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Oct 19, 2018

The Artifact Comparison checks never worked for PRs targeting non-master, it can be ignored.

@codebytere codebytere merged commit ef4a7e2 into 3-0-x Oct 19, 2018

17 of 18 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 19, 2018

No Release Notes

@alexeykuzmin alexeykuzmin deleted the backport-3-0-x-15252 branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment