Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[wip] feat: use GtkFileChooserNative for GTK File Dialog #15293
GtkFileChooserNative has support for FileChooser XDG Portal.
Signed-off-by: Denis Falqueto firstname.lastname@example.org
Notes: Use native file chooser dialog for opening and saving files.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
ckerr left a comment
I'm a little unsure about the use case for this patch and would like to get some discussion on it before it's merged.
First, this is a first submitter patch and I'm always happy to see people improving Linux support, so I'm happy to see this patch.
But I'm not certain it's wise to require GTK+ 3.20 or higher, as that would break out-of-the-box support for Ubuntu 16.04 and older.
I'm also not sure what the use case for this patch is: Electron apps running on Windows or macOS likely won't be using
@ckerr GTK+ provides a mechanism for indirecting native dialogs through a desktop-provided out-of-process common dialog handler when
There are two main reasons to do this:
@TingPing, I'd be OK with a runtime check. How would this be done?
I suppose we could use dlopen + dlsym, but I'm not sure what the implications are of doing that when we already have a normal initialized GTK+ session?
Yup. It is safe:
referenced this pull request
Nov 14, 2018
(but the conversation about dynamically loading the symbols should probably be handled also)