New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ability to fetch separators by id (backport: 3-0-x) #15299

Merged
merged 1 commit into from Oct 20, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Oct 19, 2018

Description of Change

Backport of #15290.

Checklist

Release Notes

Notes: fixes ability to fetch separators menu items by id

@codebytere codebytere requested a review from electron/reviewers as a code owner Oct 19, 2018

@codebytere codebytere merged commit 02cd968 into 3-0-x Oct 20, 2018

18 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 20, 2018

Release Notes Persisted

fixes ability to fetch separators menu items by id

@codebytere codebytere deleted the menuitem-sep-bp branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment