New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: we don't emit an event object for session-created (backport: 2-0-x) #15306

Merged
merged 1 commit into from Oct 21, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Oct 21, 2018

Backport of #15236

See that PR for details.

Notes: fixed documentation for the session-created event

@trop trop bot requested a review from electron/docs as a code owner Oct 21, 2018

@trop trop bot added 2-0-x backport labels Oct 21, 2018

@codebytere codebytere merged commit d45c290 into electron:2-0-x Oct 21, 2018

13 of 14 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 21, 2018

Release Notes Persisted

fixed documentation for the session-created event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment