Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct reversed logic in NativeWindowMac::SetEnabled (2-0-x) #15322

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@BinaryMuse
Copy link
Member

BinaryMuse commented Oct 22, 2018

Manual backport of #15257

Notes: fix: correct reversed logic in BrowserWindow#setEnabled on macOS

@BinaryMuse BinaryMuse added the backport label Oct 22, 2018

@BinaryMuse BinaryMuse requested a review from as a code owner Oct 22, 2018

@BinaryMuse BinaryMuse changed the title fix: correct reversed logic in NativeWindowMac::SetEnabled fix: correct reversed logic in NativeWindowMac::SetEnabled (2-0-x) Oct 22, 2018

@BinaryMuse BinaryMuse added 2-0-x and removed target/2-0-x labels Oct 22, 2018

@ckerr

ckerr approved these changes Oct 22, 2018

Copy link
Member

ckerr left a comment

👍

@MarshallOfSound MarshallOfSound merged commit a03da04 into 2-0-x Oct 23, 2018

16 of 17 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 23, 2018

Release Notes Persisted

fix: correct reversed logic in BrowserWindow#setEnabled on macOS

@MarshallOfSound MarshallOfSound deleted the mkt/manual-backport-15257 branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.