chore: bump minimum supported macOS version to 10.10 #15357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
requested review from
a team,
MarshallOfSound,
ckerr,
codebytere and
nornagon
nornagon
approved these changes
Oct 24, 2018
Co-Authored-By: miniak <milan.burda@gmail.com>
Co-Authored-By: miniak <milan.burda@gmail.com>
alexeykuzmin
approved these changes
Oct 24, 2018
Contributor
|
@electron/docs can you please review? |
MarshallOfSound
approved these changes
Oct 24, 2018
4 tasks
|
Release Notes Persisted
|
Contributor
|
We have automatically backported this PR to "4-0-x", please check out #15391 |
miniak
added a commit
that referenced
this pull request
Oct 28, 2018
jkleinsc
pushed a commit
that referenced
this pull request
Oct 31, 2018
3 tasks
This was referenced Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Chromium no longer supports macOS 10.9 (OS X Mavericks). Electron needs to drop support as well.
https://chromium-review.googlesource.com/c/chromium/src/+/1082757
There is a lot of code to cleanup as well, but
mac_deployment_targetis still set to 10.9 inbuild/config/mac/mac_sdk.gni, therefore we cannot remove the@available(macOS 10.10, *)checks yet.Checklist
npm testpassesRelease Notes
Notes: Dropped support for macOS 10.9 (OS X Mavericks).