New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum supported macOS version to 10.10 #15357

Merged
merged 3 commits into from Oct 25, 2018

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

miniak commented Oct 24, 2018

Description of Change

Chromium no longer supports macOS 10.9 (OS X Mavericks). Electron needs to drop support as well.
https://chromium-review.googlesource.com/c/chromium/src/+/1082757

There is a lot of code to cleanup as well, but mac_deployment_target is still set to 10.9 in build/config/mac/mac_sdk.gni, therefore we cannot remove the @available(macOS 10.10, *) checks yet.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Dropped support for macOS 10.9 (OS X Mavericks).

@miniak miniak requested review from electron/docs as code owners Oct 24, 2018

@miniak miniak self-assigned this Oct 24, 2018

@miniak miniak added the target/4-0-x label Oct 24, 2018

Show resolved Hide resolved docs/tutorial/development-environment.md Outdated
Show resolved Hide resolved docs/tutorial/support.md Outdated

nornagon and others added some commits Oct 24, 2018

OS X Yosemite -> Yosemite
Co-Authored-By: miniak <milan.burda@gmail.com>
OS X Yosemite -> Yosemite
Co-Authored-By: miniak <milan.burda@gmail.com>
@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Oct 24, 2018

@electron/docs can you please review?

@miniak miniak referenced this pull request Oct 25, 2018

Closed

chore: remove macOS 10.9 specific code #15174

4 of 4 tasks complete

@alexeykuzmin alexeykuzmin merged commit 1f3a891 into master Oct 25, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 25, 2018

Release Notes Persisted

Dropped support for macOS 10.9 (OS X Mavericks).

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 25, 2018

We have automatically backported this PR to "4-0-x", please check out #15391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment