New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump libcc (3-0-x) #15374

Merged
merged 3 commits into from Oct 24, 2018

Conversation

Projects
None yet
4 participants
@jkleinsc
Contributor

jkleinsc commented Oct 24, 2018

Description of Change

Fixes CircleCI issue where mac builds were not working.

Resolves #15344.

Updating libcc reference to latest. Changes since the last roll:

  • 82816aba fix: proxy resolution from pac file for ws requests on windows and macOS (#696)

Backports https://chromium-review.googlesource.com/c/chromium/src/+/1143093

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Oct 24, 2018

@@ -8,6 +8,7 @@ build-steps: &build-steps
echo 'Installing Node.js 10 for MacOS'
brew update
brew install node@10
echo 'export PATH="/usr/local/opt/node@10/bin:$PATH"' >> $BASH_ENV

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Oct 24, 2018

Contributor

Do we have to do the same in the master?

This comment has been minimized.

@jkleinsc

jkleinsc Oct 24, 2018

Contributor

@alexeykuzmin Yeah probably. I'll add another PR for that one.

@jkleinsc

This comment has been minimized.

Contributor

jkleinsc commented Oct 24, 2018

@alexeykuzmin ahh... you are right! I'll put up another PR to test the CircleCI change.

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Oct 24, 2018

@jkleinsc I'm not right =/ even removed that comment.
The VSTS jobs here are just "placeholders" https://github.visualstudio.com/electron/_build/results?buildId=18247&view=logs, since it's a PR to 3-0-x.

@jkleinsc jkleinsc referenced this pull request Oct 24, 2018

Merged

ci: make sure brew installed node is available in path #15377

3 of 3 tasks complete

@alexeykuzmin alexeykuzmin merged commit 9e03783 into 3-0-x Oct 24, 2018

18 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 24, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment