New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable FixAltGraph to fix Ctrl+Alt accelerators on Windows #15378

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
6 participants
@brenca
Member

brenca commented Oct 24, 2018

Description of Change

Windows treats Ctrl+Alt as AltGr, and this causes confusion when checking if an accelerator was pressed or not. There is a fix in chromium, but in C66 it's behind a flag, so we must enable it to use those accelerators.

This is only required on 3-0-x. Fixes #14674.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fixes Ctrl+Alt+<x> accelerators on Windows

@brenca brenca added the 3-0-x label Oct 24, 2018

@brenca brenca requested a review from electron/reviewers as a code owner Oct 24, 2018

@ckerr

ckerr approved these changes Oct 24, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Oct 24, 2018

Mac failures were fixed in #15374 about an hour ago. Please rebase.

@nornagon

This comment has been minimized.

@fxha fxha referenced this pull request Oct 25, 2018

Closed

Ctrl+Alt+* shortcut doesn't work on Windows #523

1 of 1 task complete
@brenca

This comment has been minimized.

Member

brenca commented Oct 25, 2018

@nornagon I guess that patch is relevant, but I'm not sure why we have that patch or what would break if we didn't 😄

@MarshallOfSound MarshallOfSound merged commit 809534d into 3-0-x Oct 29, 2018

17 of 18 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 29, 2018

Release Notes Persisted

fixes Ctrl+Alt+<x> accelerators on Windows

@MarshallOfSound MarshallOfSound deleted the brenca/fix-14674 branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment