New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folder open not working in devtools (backport: 4-0-x) #15397

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
1 participant
@trop
Contributor

trop bot commented Oct 25, 2018

Backport of #15387

See that PR for details.

Resolves #15360

Notes: fix crash when showing source folder in devtools

@trop trop bot requested a review from electron/reviewers as a code owner Oct 25, 2018

@trop trop bot referenced this pull request Oct 25, 2018

Merged

fix: folder open not working in devtools #15387

3 of 3 tasks complete

@trop trop bot added 4-0-x backport labels Oct 25, 2018

@codebytere codebytere merged commit d16304f into electron:4-0-x Oct 25, 2018

18 of 20 checks passed

ci/circleci: mas-testing CircleCI is running your tests
Details
ci/circleci: osx-testing-tests CircleCI is running your tests
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 25, 2018

Release Notes Persisted

fix crash when showing source folder in devtools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment