New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: skip pyproto/ resources in zip.py (backport: 4-0-x) #15398

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@trop
Contributor

trop bot commented Oct 25, 2018

Backport of #15348

See that PR for details.

Notes: removed unneeded pyproto files from release archives

@trop trop bot requested a review from electron/reviewers as a code owner Oct 25, 2018

@trop trop bot referenced this pull request Oct 25, 2018

Merged

build: skip pyproto/ resources in zip.py #15348

2 of 2 tasks complete

@trop trop bot added 4-0-x backport labels Oct 25, 2018

@jkleinsc jkleinsc merged commit 6e759e0 into electron:4-0-x Oct 25, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 25, 2018

Release Notes Persisted

removed unneeded pyproto files from release archives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment