Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve printing related bugs on 3-0-x #15402

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@brenca
Copy link
Member

brenca commented Oct 25, 2018

Description of Change

I tried to fix #14705 but ended up fixing #15036 too.

This is all related to outdated sources in chromium_src, the shared memory handles now trigger a DCHECK if you close one that's already invalid, and the printing debug dump call created junk files, and was also triggering a breakpoint, which I guess shouldn't happen.

With this I can print to pdf with the Microsoft Print To PDF thing twice in a row, without crash.
#14260 might be related, might be fixed by this, since I can see all pages when I print to PDF.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fixed printing related bugs on Windows

@brenca brenca added the 3-0-x label Oct 25, 2018

@brenca brenca requested a review from as a code owner Oct 25, 2018

@ckerr ckerr merged commit bdda248 into 3-0-x Oct 26, 2018

18 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 26, 2018

Release Notes Persisted

fixed printing related bugs on Windows

@ckerr ckerr deleted the brenca/fix-printing-3-0-x branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.