Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use gio as default linux trash impl (backport: 3-0-x) #15421

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

trop bot commented Oct 26, 2018

Backport of #15399

See that PR for details.

Resolves #15011

Notes: fix default trash impl on linux to use gio

@trop trop bot requested review from as code owners Oct 26, 2018

@trop trop bot referenced this pull request Oct 26, 2018

Merged

fix: use gio as default linux trash impl #15399

3 of 3 tasks complete

@trop trop bot added 3-0-x backport labels Oct 26, 2018

@codebytere codebytere merged commit b6b9966 into electron:3-0-x Oct 26, 2018

12 of 14 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 26, 2018

Release Notes Persisted

fix default trash impl on linux to use gio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.